[Marble-devel] Re: Review Request: Option to delete theme

Torsten Rahn rahn at kde.org
Wed Dec 22 11:16:13 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6180/#review9363
-----------------------------------------------------------


Hm, the patch doesn't seem to apply cleanly :-( Can you fix it? Otherwise it looks good.

- Torsten


On 2010-12-21 21:09:48, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6180/
> -----------------------------------------------------------
> 
> (Updated 2010-12-21 21:09:48)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds an option to delete a theme if it is located in the home directory of the user. Sub-directories and the theme directory are removed if there is no other data in them. The mapwizard-patch is required to apply this patch.
> 
> This patch was created for a GCI task:
> http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129258692177
> 
> Update: Private functions are now in the private class.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h 1208364 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp 1208364 
> 
> Diff: http://svn.reviewboard.kde.org/r/6180/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101222/3812bbb9/attachment.htm 


More information about the Marble-devel mailing list