[Marble-devel] Re: Review Request: Map Creation Wizard

[Utku Aydin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6070/
-----------------------------------------------------------

(Updated 2010-12-22 07:15:04.798794)


Review request for marble, Torsten Rahn and Dennis Nienhüser.


Changes
-------

Corrected the issues which Dennis Nienhüser mentioned.


Summary
-------

Map wizard helps users create a new map easily.


Diffs (updated)
-----

  trunk/KDE/kdeedu/marble/src/ControlView.h 1207748 
  trunk/KDE/kdeedu/marble/src/ControlView.cpp 1207748 
  trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1207748 
  trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1207748 
  trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1207748 
  trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.h 1207748 
  trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.cpp 1207748 
  trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.ui 1207748 
  trunk/KDE/kdeedu/marble/src/lib/MapWizard.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/MapWizard.ui PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.h 1207748 
  trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1207748 
  trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h 1207748 
  trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp 1207748 
  trunk/KDE/kdeedu/marble/src/marble.kcfg 1207748 
  trunk/KDE/kdeedu/marble/src/marble_part.h 1207748 
  trunk/KDE/kdeedu/marble/src/marble_part.cpp 1207748 

Diff: http://svn.reviewboard.kde.org/r/6070/diff


Testing
-------

Tested WMS and online map cases with different servers and source bitmap case with different source images.

* Validates the data properly.
* Creates the legend.
* Downloads and shows tiles from both WMS and a static HTTP URL properly.

Tested servers:
* http://onearth.jpl.nasa.gov/wms.cgi (WMS)
* http://tile.openstreetmap.org (online map)
* http://andy.sandbox.cloudmade.com/tiles/cycle/ (online map)
* http://mt.google.com/vt/lrys=m@130&hl=tr&x={x}&y={y}&z={zoomLevel}&s=Ga

Note:
I didn't test upload feature because the server is not available at the moment.


Screenshots
-----------

Step One
  http://svn.reviewboard.kde.org/r/6070/s/577/
Step Two
  http://svn.reviewboard.kde.org/r/6070/s/578/


Thanks,

Utku

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101222/d758e95f/attachment-0001.htm