[Marble-devel] Re: Review Request: Map Creation Wizard

[Torsten Rahn]

> On 2010-12-16 21:34:43, Torsten Rahn wrote:
> > The patch is nice but it's too OSM specific. The patch is supposed to implement the "custom" mode for static Url online maps. This requires a bit of renaming and small adjustments still in order to be considered complete. Otherwise great work!
> 
> Alexandre Viard wrote:
>     Due to the case mispelling in my previous comment... It remain in marble_part.cpp line 615 : SetWmsServices instead of setWmsServices.
> 
> Utku Aydin wrote:
>     Well, it was setWmsServices in diff r5 and I renamed it to SetWmsServices as you said in your previous comment. Which one is correct?
> 
> Alexandre Viard wrote:
>     in diffr5 it was setWMSServices and the good signature was setWmsServices, but i mistyped SetWmsServices.  so the correct one is  "setWmsServices". I also have frequently case related problems ^_^
> 
> Utku Aydin wrote:
>     Oh, sorry. I thought that I should only change the first letter, didn't notice the others. :) Thanks.

gOoD tHaT wE fInAlLy AgReE oN tHe CaSe ReLaTeD pRoBlEmS .... ;-)


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6070/#review9279
-----------------------------------------------------------


On 2010-12-17 11:06:52, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6070/
> -----------------------------------------------------------
> 
> (Updated 2010-12-17 11:06:52)
> 
> 
> Review request for marble, Torsten Rahn and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> Map wizard helps users create a new map easily.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1206280 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.ui 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.ui PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp 1206280 
>   trunk/KDE/kdeedu/marble/src/marble.kcfg 1206280 
>   trunk/KDE/kdeedu/marble/src/marble_part.h 1206280 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1206280 
> 
> Diff: http://svn.reviewboard.kde.org/r/6070/diff
> 
> 
> Testing
> -------
> 
> Tested WMS and online map cases with different servers and source bitmap case with different source images.
> 
> * Validates the data properly.
> * Creates the legend.
> * Downloads and shows tiles from both WMS and a static HTTP URL properly.
> 
> Tested servers:
> * http://onearth.jpl.nasa.gov/wms.cgi (WMS)
> * http://tile.openstreetmap.org (online map)
> * http://andy.sandbox.cloudmade.com/tiles/cycle/ (online map)
> * http://mt.google.com/vt/lrys=m@130&hl=tr&x={x}&y={y}&z={zoomLevel}&s=Ga
> 
> 
> Screenshots
> -----------
> 
> Step One
>   http://svn.reviewboard.kde.org/r/6070/s/577/
> Step Two
>   http://svn.reviewboard.kde.org/r/6070/s/578/
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101217/2beec394/attachment.htm