[Marble-devel] Re: Review Request: Map Creation Wizard

[Utku Aydin]

> On 2010-12-14 21:51:05, Torsten Rahn wrote:
> > Great work. Could you resolve the remaining minor issues that I pointed out? :-)
> 
> Utku Aydin wrote:
>     They are resolved in diff r5, thanks for pointing out.
> 
> Alexandre Viard wrote:
>     A small case problem remain in marble_part.cpp line 615 : setWMSServices instead of SetWmsServices
> 
> Torsten Rahn wrote:
>     Alexandre: Good catch. Yes, that needs to be fixed.

Fixed, thanks.


- Utku


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6070/#review9254
-----------------------------------------------------------


On 2010-12-15 12:24:57, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6070/
> -----------------------------------------------------------
> 
> (Updated 2010-12-15 12:24:57)
> 
> 
> Review request for marble, Torsten Rahn and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> Map wizard helps users create a new map easily.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1206280 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.ui 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.ui PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h 1206280 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp 1206280 
>   trunk/KDE/kdeedu/marble/src/marble.kcfg 1206280 
>   trunk/KDE/kdeedu/marble/src/marble_part.h 1206280 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1206280 
> 
> Diff: http://svn.reviewboard.kde.org/r/6070/diff
> 
> 
> Testing
> -------
> 
> I tested the wizard in different situations and it doesn't let the user overwrite the existing maps. Also it warns the user properly if there is an invalid input.
> 
> 
> Screenshots
> -----------
> 
> Step One
>   http://svn.reviewboard.kde.org/r/6070/s/577/
> Step Two
>   http://svn.reviewboard.kde.org/r/6070/s/578/
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101216/4775d950/attachment-0001.htm