[Marble-devel] Re: Review Request: Confirmation before removing all bookmarks

[Michael Hansen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6122/#review9265
-----------------------------------------------------------

Ship it!


Works fine - but why have YesNoCancel, when there is not really a difference between No and Cancel?

Thanks for the quick fix,

Michael

- Michael


On 2010-12-15 21:11:08, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6122/
> -----------------------------------------------------------
> 
> (Updated 2010-12-15 21:11:08)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This adds a confirmation dialog to the Qt and KDE applications shown to confirm the deletion of bookmarks. Can I get a quick test for the KDE version, please? Mine has a corrupt UI since some time and somehow I'm not able to fix that (the menu is totally screwed up, no actions except the help menu. Recompiling from scratch doesn't help).
> 
> The new string is already acknowledged by translators, so let's get this in quickly before they change their minds. Thanks.
> 
> 
> This addresses bug 259655.
>     https://bugs.kde.org/show_bug.cgi?id=259655
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1206537 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1206537 
> 
> Diff: http://svn.reviewboard.kde.org/r/6122/diff
> 
> 
> Testing
> -------
> 
> Works fine in Qt, but needs someone to test in the KDE version.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101215/64f08e75/attachment.htm