[Marble-devel] Re: Review Request: Map Creation Wizard

Utku Aydin utkuaydin34 at gmail.com
Wed Dec 8 17:37:23 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6070/
-----------------------------------------------------------

(Updated 2010-12-08 16:37:22.797596)


Review request for marble, Torsten Rahn and Dennis Nienhüser.


Changes
-------

I have done what Torsten said. I hope this one is correct.


Summary
-------

Map wizard helps users create a new map easily. It queries the new map's details including base tile image and preview image.


Diffs (updated)
-----

  trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1202078 
  trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1202078 
  trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1202078 
  trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.ui 1202078 
  trunk/KDE/kdeedu/marble/src/lib/MapWizard.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/MapWizard.ui PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h 1202078 
  trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp 1202078 

Diff: http://svn.reviewboard.kde.org/r/6070/diff


Testing
-------

I tested the wizard in different situations and it doesn't let the user overwrite the existing maps. Also it warns the user properly if there is an invalid input.


Screenshots
-----------

Step One
  http://svn.reviewboard.kde.org/r/6070/s/577/
Step Two
  http://svn.reviewboard.kde.org/r/6070/s/578/


Thanks,

Utku

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101208/f7ee1908/attachment.htm 


More information about the Marble-devel mailing list