[Marble-devel] Re: Review Request: [Patch] Review Request for Bug 232098 - JJ: Please add fast adding messurment points by ctrl+click [MEDIUM]

[Thomas Lenarz]

Hello,

Thanks a lot for the reply and suggestions.

I agree that the menu entry is far too long.
However, from my point of view the quirkiness of this approach is that 
it combines a mode switch and the obligation to press the 
Control-Modifier-Key.

I ended up with this solution because...

1. The feature should describe itself. Hence the long text.
2. Its use should be comfortable even if a shift of the map is necessary 
to extend the track outside the currently visible area.

 From your proposals I like the last one best: Choosing a different 
modifier key. I would like to suggest [SHIFT]. It appears to be the one 
of [ALT],[CTRL],[SHIFT] which is free. [ALT] + left-click appears to 
grab and move the whole window. At least within Gnome. I don't know how 
it is like in KDE.

However, I see the problem how the user will get to know of this option 
without reading any help-file or documentation?
(That is probably the same problem like it is with the CTRL + 
left-mouse-drag option. I see that a rubber-band opens up and disappears 
again. So far I haven't found out what it actually does...)

I thought of a real measurement mode as well but did not think of a 
toggle toolbar buttongroup. I like this idea very much because it would 
be instantaneously clear to the user how it works.

Nonetheless, I see a drawback when measuring a longer track. It can be 
necessary to move the map around while adding measure-points. It would 
be cumbersome to move the mouse-pointer away from the map to operate the 
toolbar button, move the map, operate the toolbar button again and then 
get back to the position for next the measure-point.

The modifier comes here in handy: Insert some points with 
[SHIFT]-pressed, release [SHIFT], move the map, (mouse pointer is 
exactly at the position where it should be), carry on inserting points.

All the Best,
Thomas


Am 28.11.2010 22:16, schrieb Torsten Rahn:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6003/#review9022
> -----------------------------------------------------------
>
>
> I don't think that this solution is appropriate (sorry ...):
> First I don't think that the RMB menu is the right place to toggle between these modes. This kind of option feels like a convenience feature for power users. And the context menu isn't the right place for toggling this kind of stuff (also the length of the menu entry which tries to explain at length what it does is way too long for a context menu entry -- keep in mind that in other languages the translation is up to 3x as long as the english version).
>
> I see other possible solutions:
>
> * this kind of option could go into the Navigation settings dialog
> OR
> * we introduce a real measurement mode (entered via a toggle toolbar buttongroup) where a single click already creates new measurement nodes
> OR
> * we find a different modifier key for the creation of nodes for power-users
>
> So no "Ship it" from me yet for the suggested solution.
>
>
> - Torsten
>
>
> On 2010-11-28 18:01:07, Thomas Lenarz wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://svn.reviewboard.kde.org/r/6003/
>> -----------------------------------------------------------
>>
>> (Updated 2010-11-28 18:01:07)
>>
>>
>> Review request for marble.
>>
>>
>> Summary
>> -------
>>
>> I would like to propose a second patch for this junior job (Bug 232098: Fast adding of measure-points using ctrl+click).
>>
>> It still uses the CTRL modifier key. However, "measure mode" has to be switched on via a new added menu toggle option within the right-mouse-button menu. This should avoid the conflict with the rubber-band-selection using the CTRL modifier key as well.
>> When in "measure mode" the mouse-pointer changes to the "arrow-up"-pointer when CTRL is pressed to indicate the different behaviour.
>>
>> Best wishes,
>>
>> Thomas
>>
>>
>> This addresses bug 232098.
>>      https://bugs.kde.org/show_bug.cgi?id=232098
>>
>>
>> Diffs
>> -----
>>
>>    /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetInputHandler.cpp 1201666
>>
>> Diff: http://svn.reviewboard.kde.org/r/6003/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Screenshots
>> -----------
>>
>> fastmeasurement
>>    http://svn.reviewboard.kde.org/r/6003/s/566/
>>
>>
>> Thanks,
>>
>> Thomas
>>
>>
>
>