[Marble-devel] Review Request: PositionTracking: export and private

[Dennis Nienhüser]

Hi Burak,

it's the pointer to a private class which is used to keep the header 
file clean, reduce compile time and ease binary compatibility in future 
versions. You get useful information about that when searching for 
"Pimpl idiom" or "opaque pointer". See [1] for a start.

Regards,
Dennis

[1] 
http://zchydem.enume.net/2010/01/19/qt-howto-private-classes-and-d-pointers/

On 25.08.2010 22:39, Burak Alkan wrote:
> Sorry sir, I couldn't help myself, if you have a moment can you explain what
> is the 'd' in PositionTracking class? What does the code
>
> d (new PositionTrackingPrivate(fileManager, parent))
>
> do in PositionTracking ctor, and what is the use of it?
>
>
> On Wednesday 25 August 2010 20:23:30 Torsten Rahn wrote:
>    
>>> On 2010-08-25 05:22:10, Torsten Rahn wrote:
>>>        
>>>> Did this one get submitted already? I hope so. If not maybe you could
>>>> add the "disconnect" for existing connections in the setter before
>>>> doing the "connects". Otherwise looks great. Please mark as submitted.
>>>> :-)
>>>>          
>>> Torsten Rahn wrote:
>>>      Hm, I think we want a nicer UI here.
>>>      It's ok for an immediate backport to 0.10.0/1.
>>>
>>>      But we need to fix that the checkbox and the button get disabled if
>>> no position plugin is installed (like with the other buttons on that
>>> page).
>>>        
>> Oh and the Clear Track button should of course only be enabled if the "show
>>   Track" checkbox is enabled. Anything else doesn't make sense. :-)
>>
>>
>> - Torsten
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/5038/#review7207
>> -----------------------------------------------------------
>>
>> On 2010-08-15 21:34:08, Thibaut Gridel wrote:
>>      
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> http://reviewboard.kde.org/r/5038/
>>> -----------------------------------------------------------
>>>
>>> (Updated 2010-08-15 21:34:08)
>>>
>>>
>>> Review request for marble, Dennis Nienhüser and Siddharth Srivastava.
>>>
>>>
>>> Summary
>>> -------
>>>
>>> Export PositionTracking as it should, and thus make a Private to hold
>>> data. Also provide a setTrackVisible to toggle track display and a
>>> resetTrack to reset the content of the document. The
>>> CurrentLocationWidget is updated as a proof of concept, please comment on
>>> UI aspects ;)
>>>
>>> This patch should be useful to both Torch and bryang, who make use of the
>>> track display...
>>>
>>>
>>> Diffs
>>> -----
>>>
>>>    /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/PositionTracking.h PRE-CREATION
>>>    /trunk/KDE/kdeedu/marble/src/lib/PositionTracking.cpp PRE-CREATION
>>>    /trunk/KDE/kdeedu/marble/src/lib/PositionTracking_p.h PRE-CREATION
>>>    /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp 1164098
>>>    /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp 1164098
>>>
>>> /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker
>>> .cpp 1164098
>>> /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp
>>> 1164098
>>>
>>> Diff: http://reviewboard.kde.org/r/5038/diff
>>>
>>>
>>> Testing
>>> -------
>>>
>>> Various toggles in the Current Location widget.
>>>
>>>
>>> Thanks,
>>>
>>> Thibaut
>>>        
>>      
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel
>
>