[Marble-devel] Review Request: Use MarbleModel rather than MarbleMap in Runners

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5075/#review7173
-----------------------------------------------------------

Ship it!


Looks good, please commit.

- Dennis


On 2010-08-20 10:19:30, Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5075/
> -----------------------------------------------------------
> 
> (Updated 2010-08-20 10:19:30)
> 
> 
> Review request for marble and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> MarbleRunners seem to operate on Data, but do not perform graphical operations. MarbleModel provides data without having a bias to a graphical representation (MarbleWidget or MarbleMap). Thus, using MarbleModel instead of MarbleMap in the runners would make them more agnostic to the graphical representation.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleAbstractRunner.h 1165864 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleAbstractRunner.cpp 1165864 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1165864 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleRunnerManager.h 1165864 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleRunnerManager.cpp 1165864 
>   /trunk/KDE/kdeedu/marble/src/plugins/runner/localdatabase/LocalDatabaseRunner.cpp 1165864 
> 
> Diff: http://reviewboard.kde.org/r/5075/diff
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100823/0c983dd0/attachment.htm