[Marble-devel] Review Request: Oxygen style progress animation

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5089/
-----------------------------------------------------------

(Updated 2010-08-23 12:10:06.431398)


Review request for marble and Torsten Rahn.


Summary
-------

Replaces the progress.mng animation used for the routing related buttons with an animation rendered in-memory. The new animation mimics the oxygen busy cursor (two white balls rotating around each other). This should fix the progress animation not appearing under Windows and Maemo (which probably lack mng support).

Patch is for trunk, but I intend to backport it to branches/4.5.


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/libmarble.qrc 1166756 
  /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.h 1166756 
  /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.cpp 1166756 
  /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.cpp 1166756 

Diff: http://reviewboard.kde.org/r/5089/diff


Testing (updated)
-------

Only with X11 so far, but the new animation does not rely on external files or formats anymore -- chances are good it works everywhere now.
Update: Works fine with Maemo (Scratchbox).


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100823/5ec17865/attachment.htm