[Marble-devel] Review Request: Bookmark Feature : Icons, Coordinate in bookmarks.kml and Edit Bookmark

[1989.gaurav at gmail.com]

> On 2010-08-15 14:07:37, Torsten Rahn wrote:
> > /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp, line 45
> > <http://reviewboard.kde.org/r/5034/diff/3/?file=33977#file33977line45>
> >
> >     This needs to be removed I guess.

Done


- 1989gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5034/#review7071
-----------------------------------------------------------


On 2010-08-15 13:59:02, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5034/
> -----------------------------------------------------------
> 
> (Updated 2010-08-15 13:59:02)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added Icons in Bookmark menu.
> Added GeoDataCoordinate in bookmark.kml file along with lookAt.
> Added ExtendedData Tag writer to write in bookmark.kml file.
> Adding Edit Bookmark Feature along with some modification in GeoDataTreeModel ( In Process )
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1163977 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.h 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.cpp 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp 1163977 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlExtendedDataTagWriter.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlExtendedDataTagWriter.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.cpp 1163977 
>   /trunk/KDE/kdeedu/marble/src/marble.qrc 1163977 
> 
> Diff: http://reviewboard.kde.org/r/5034/diff
> 
> 
> Testing
> -------
> 
> Running
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100815/8e6450e8/attachment.htm