[Marble-devel] Review Request: Bookmark Feature : Icons, Coordinate in bookmarks.kml and Edit Bookmark

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5034/#review7067
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/EditBookmarkDialog.h
<http://reviewboard.kde.org/r/5034/#comment7143>

    Since this class is getting exported, could you add d-pointers to the class? 
    
    See:
    http://techbase.kde.org/Policies/Library_Code_Policy#D-Pointers
    
    Rule of thumb: All classes that are part of the public API should have D-Pointers. Even for those which are not public API it's considered good style to have D-Pointers :-)



/trunk/KDE/kdeedu/marble/src/lib/EditBookmarkDialog.cpp
<http://reviewboard.kde.org/r/5034/#comment7144>

    Why not instantiate the FileManager with the parent:
    
    m_fileManager = new FileManager( this );
    
    Then you can get rid of the "delete m_fileManager;" in the dtor


- Torsten


On 2010-08-15 11:48:00, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5034/
> -----------------------------------------------------------
> 
> (Updated 2010-08-15 11:48:00)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added Icons in Bookmark menu.
> Added GeoDataCoordinate in bookmark.kml file along with lookAt.
> Added ExtendedData Tag writer to write in bookmark.kml file.
> Adding Edit Bookmark Feature along with some modification in GeoDataTreeModel ( In Process )
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1162829 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1162829 
>   /trunk/KDE/kdeedu/marble/src/icons/bookmarkAddFolder.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/src/icons/bookmarkEdit.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/src/icons/bookmarkNew.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/src/icons/bookmarkRemove.png UNKNOWN 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.h 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.cpp 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/EditBookmarkDialog.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/EditBookmarkDialog.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/EditBookmarkDialog.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp 1162829 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlExtendedDataTagWriter.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlExtendedDataTagWriter.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.cpp 1162829 
>   /trunk/KDE/kdeedu/marble/src/marble.qrc 1162829 
> 
> Diff: http://reviewboard.kde.org/r/5034/diff
> 
> 
> Testing
> -------
> 
> Running
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100815/32a0afdd/attachment.htm