[Marble-devel] Review Request: Interface for Small Screen Devices

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5011/#review7026
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h
<http://reviewboard.kde.org/r/5011/#comment7059>

    Although it's already checked -- setRecenterMode would be a better method name



/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h
<http://reviewboard.kde.org/r/5011/#comment7060>

    updateRecenterComboBox
    
    can this be private?



/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h
<http://reviewboard.kde.org/r/5011/#comment7061>

    updateAutoZoomCheckBox.
    
    private, if possible.



/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp
<http://reviewboard.kde.org/r/5011/#comment7062>

    My suggestion to put AdjustNavigation into RoutingManager is not a too good choice as idis pointed out. Thinking that it will be used by others pretty soon (from plugins), I think we should spend more thought on where to put this. Suggestions, anyone?
    



/trunk/KDE/kdeedu/marble/src/marble.qrc
<http://reviewboard.kde.org/r/5011/#comment7058>

    the icons are all either self-created or from oxygen?


- Dennis


On 2010-08-12 20:11:20, Siddharth Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5011/
> -----------------------------------------------------------
> 
> (Updated 2010-08-12 20:11:20)
> 
> 
> Review request for marble and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> An interface of Routing Plugin for Small Screen Devices is added. The Routing Plugin for Small Screen Device contains options for navigation( recenter, auto zoom), routing information widget, zoom in and zoom out functionalities.
> The routing information widget for desktop version of marble, now shows the next instruction as well as the distance remaining to reach it.
> 
> The instruction point now grows in two levels when the gps location gets closer to it instead of displaying the instruction text at it. 1) The instruction point going to be visited grows in size 2) When the gps device is at certain time away from the instruction point, it grows a bit further.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/graphicsview/ScreenGraphicsItem_p.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/marble.qrc 1162824 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/CMakeLists.txt 1162824 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidgetSmall.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingItemWidget.ui 1162824 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h 1162824 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp 1162824 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingWidgetSmall.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/5011/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Siddharth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100813/f3a07ad7/attachment-0001.htm