[Marble-devel] Review Request: GeometryLayer: a permanent layer which replaces Georender plugin

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4990/
-----------------------------------------------------------

Review request for marble.


Summary
-------

The GeometryLayer is added as a permanent layer in MarbleModel, because we need to rely on this layer without a plugin.
There are many fixes compared to the GeoRender code:
 - it is not a Model/View class anymore as that brought a lot of unused boilerplate and we don't react to model signals anyway
 - no more hacks to try and determine styling on the fly, this is delegated after file loading in PlacemarkManager
 - internal data in private class

GeoDataFeature::style now points at the current style identified in the document. The setStyle doesn't do it (yet)
There is a conflict between the geodatadocument style and the VisualCategory one. Please check that I didn't break too much there...


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1162401 
  /trunk/KDE/kdeedu/marble/src/lib/FileManager.h 1162401 
  /trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp 1162401 
  /trunk/KDE/kdeedu/marble/src/lib/GeometryLayer.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/GeometryLayer.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1162401 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.h 1162401 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.cpp 1162401 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1162401 
  /trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1162401 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/CMakeLists.txt 1162401 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.h 1162401 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.cpp 1162401 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.h 1162401 
  /trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.cpp 1162401 

Diff: http://reviewboard.kde.org/r/4990/diff


Testing
-------

Loaded various kml/pnt/gpx files (including Marble Writing).
Displayed positiontracking track.
Rendering unchanged for the most (default styling now is that of GeoDataVisualCategory::Default)


Thanks,

Thibaut

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100811/dab8caf4/attachment.htm