[Marble-devel] Review Request: Use english as a fallback language code when ORS cannot handle the system locale

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4987/
-----------------------------------------------------------

Review request for marble.


Summary
-------

The language code to generate instructions for is taken from the system locale in Marble. ORS does not handle all locales and reports an error if it does not know one. Currently Marble informs the user about the problem with an error dialog. The patch changes this to catch the error early and generate a new request with english as the fallback language code. This way routes are retrieved, although not localized.


This addresses bug 247339.
    https://bugs.kde.org/show_bug.cgi?id=247339


Diffs
-----

  /branches/KDE/4.5/kdeedu/marble/src/lib/routing/OrsRoutingProvider.h 1160574 
  /branches/KDE/4.5/kdeedu/marble/src/lib/routing/OrsRoutingProvider.cpp 1160574 

Diff: http://reviewboard.kde.org/r/4987/diff


Testing
-------

LC_ALL=C, de_DE, fr_FR, en_US, nn_NO (the latter generating the error in stable)


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100811/90b07b5e/attachment.htm