[Marble-devel] Review Request: Bookmark name suggestion

[Dennis Nienhüser]

> On 2010-08-10 15:44:32, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 55
> > <http://reviewboard.kde.org/r/4954/diff/5/?file=33541#file33541line55>
> >
> >     Not strictly needed since you pass this as the parent when constructing the manager, so it'd be deleted automatically.
> 
> 1989gaurav wrote:
>     I didn't understand why its not strictly required?

QObject deletes its children automatically in its destructor. In code like

QObject* parent = new QObject;
QObject* child = new QObject(parent);
delete parent;

the deletion of parent in the last line will automatically result in the deletion of child as well.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4954/#review6967
-----------------------------------------------------------


On 2010-08-10 15:41:40, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4954/
> -----------------------------------------------------------
> 
> (Updated 2010-08-10 15:41:40)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added auto selection of Bookmark name and suboptimal suggestions by reverseGeocoding the coordinates.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/NewFolderInfoDialog.h 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/NewFolderInfoDialog.cpp 1161074 
> 
> Diff: http://reviewboard.kde.org/r/4954/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100810/d4c44de6/attachment.htm