[Marble-devel] Review Request: Bookmark name suggestion

[1989.gaurav at gmail.com]

> On 2010-08-10 14:45:55, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 78
> > <http://reviewboard.kde.org/r/4954/diff/4/?file=33508#file33508line78>
> >
> >     Another possibility would be to include coordinates.toString() here to get a suggestion that should nearly always be unique

Done


> On 2010-08-10 14:45:55, Dennis Nienhüser wrote:
> > trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp, line 100
> > <http://reviewboard.kde.org/r/4954/diff/4/?file=33508#file33508line100>
> >
> >     Use curly braces even when the body of a conditional statement contains only one line.

Corrected


- 1989gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4954/#review6959
-----------------------------------------------------------


On 2010-08-10 13:41:42, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4954/
> -----------------------------------------------------------
> 
> (Updated 2010-08-10 13:41:42)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added auto selection of Bookmark name and suboptimal suggestions by reverseGeocoding the coordinates.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui 1161074 
> 
> Diff: http://reviewboard.kde.org/r/4954/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100810/fdc1bde3/attachment.htm