[Marble-devel] Review Request: Bookmark name suggestion

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4954/#review6943
-----------------------------------------------------------



trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp
<http://reviewboard.kde.org/r/4954/#comment6941>

    Doesn't this miss separators here? Like ", " between two entries.
    
    Maybe add a private method like this:
    QString append( const QString &bookmark, const QString &text ) const {
      if ( bookmark.isEmpty() ) {
        return text;
      }
    
      return bookmark + ", " + text;
    }
    
    This way you get a well formatted text, you can deal with partially filled fields and you can still use the isEmpty() check at the end.
    
    Another thing: Please use parenthesis also for one-liners, e.g.
    
    if( distance >= 3500 )
      bookmarkName = extende...
    
    should be
    
    if( distance >= 3500 ) {
      bookmarkName = extende...
    }
    


- Dennis


On 2010-08-10 04:54:08, 1989gaurav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4954/
> -----------------------------------------------------------
> 
> (Updated 2010-08-10 04:54:08)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added auto selection of Bookmark name and suboptimal suggestions by reverseGeocoding the coordinates.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1161074 
>   trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui 1161074 
> 
> Diff: http://reviewboard.kde.org/r/4954/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> 1989gaurav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100810/ecdfd79b/attachment.htm