[Marble-devel] Review Request: Do not build geodatatest if tests are disabled

[Bastian Holst]

> On 2010-08-08 17:24:56, Dennis Nienhüser wrote:
> > I don't think geodatatest is a unit test, more a dump tool. Therefore compilation should not depend on whether tests are enabled. What about renaming it instead - to something like geodatadumper or marble-fileinspector?
> >

Oh, didn't know that. Good that i put it on reviewboard.
Renaming would be reasonable.
I'd like marble-fileinspector best.


- Bastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4937/#review6872
-----------------------------------------------------------


On 2010-08-08 17:05:08, Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4937/
> -----------------------------------------------------------
> 
> (Updated 2010-08-08 17:05:08)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Do not build geodatatest if tests are disabled.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1159231 
> 
> Diff: http://reviewboard.kde.org/r/4937/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100808/3fe6539e/attachment.htm