[Marble-devel] Review Request: Displaying timezone information

hjain.itbhu at gmail.com hjain.itbhu at gmail.com
Sat Aug 7 15:57:32 CEST 2010



> On 2010-07-21 21:22:50, Thibaut Gridel wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlStateTagHandler.h, line 21
> > <http://reviewboard.kde.org/r/4729/diff/1/?file=31677#file31677line21>
> >
> >     state is a reserved attribute in kml reference for the "current state of the NetworkLink or Folder" it is an enum value!
> >     
> >     http://code.google.com/apis/kml/documentation/kmlreference.html#state
> >     
> >     You may want to use extended data instead.

The kml tags like state, role, pop, CountryNameCode are Marble extended tags and should be stored using extended data. In future, all these tags could be shifted to extended data simultaneously.


> On 2010-07-21 21:22:50, Thibaut Gridel wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.h, line 61
> > <http://reviewboard.kde.org/r/4729/diff/1/?file=31670#file31670line61>
> >
> >     The name seems misleading. GMT is the mean time for Greenwich. Its timezone is by definition constantly 0 ;)
> >     
> >     I think you mean timezone instead.

Timezone is of two types : normal(gmt offset) and dst(dst offset). Gmt is the terminology used in data source and represents the type of timezone precisely.


> On 2010-07-21 21:22:50, Thibaut Gridel wrote:
> > /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlStateTagHandler.cpp, line 33
> > <http://reviewboard.kde.org/r/4729/diff/1/?file=31678#file31678line33>
> >
> >     Static cast would always return something. Please use .is which uses dynamic_cast and has a chance to return 0!

I will fixed it.


- hjain


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4729/#review6659
-----------------------------------------------------------


On 2010-07-21 13:51:12, hjain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4729/
> -----------------------------------------------------------
> 
> (Updated 2010-07-21 13:51:12)
> 
> 
> Review request for marble and Bastian Holst.
> 
> 
> Summary
> -------
> 
> This feature displays the timezone( gmt/dst ) and state of city placemarks in Placemark Info Dialog Box. This is partial patch. This patch does not changes in data/placemarks folder. Placemarks folder is uploaded at http://uploading.com/files/2b6d1bdf/placemarks.tar.gz/ 
> 
> Complete patch can be downloaded from http://uploading.com/files/719mmme6/timezone_final/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.h 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.cpp 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.cpp 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.ui 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark_p.h 1152371 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlStateTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlStateTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/tools/asc2kml/asc2kml.cpp 1152371 
> 
> Diff: http://reviewboard.kde.org/r/4729/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> hjain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100807/93da9846/attachment.htm 


More information about the Marble-devel mailing list