[Marble-devel] Review Request: Routino router

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4913/#review6827
-----------------------------------------------------------

Ship it!


Looks great, just some nitpicking comments. Please commit :-)


/trunk/KDE/kdeedu/marble/src/plugins/runner/routino/RoutinoRunner.cpp
<http://reviewboard.kde.org/r/4913/#comment6724>

    Whitespace missing near parenthesis, same for some other parts. Usually 
    
    astyle --indent=spaces=4 --brackets=linux \
           --indent-labels --pad-oper --pad-paren-in \
           --one-line=keep-statements --convert-tabs \
           *.h *.cpp
    
    works well to get the formatting right with one call.



/trunk/KDE/kdeedu/marble/src/plugins/runner/routino/RoutinoRunner.cpp
<http://reviewboard.kde.org/r/4913/#comment6723>

    routinfo => routino


- Dennis


On 2010-08-05 18:25:13, Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4913/
> -----------------------------------------------------------
> 
> (Updated 2010-08-05 18:25:13)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Marble router plugin that uses routino to calculate routes offline.
> 
> Usage:
> copy generated nodes.mem, segments.mem, ways.mem and profiles.xml,into
> ~/.local/share/marble/maps/earth/routino and make the router binary callable in
> PATH trough routino-router.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/runner/CMakeLists.txt 1159591 
>   /trunk/KDE/kdeedu/marble/src/plugins/runner/routino/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/runner/routino/RoutinoPlugin.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/runner/routino/RoutinoPlugin.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/runner/routino/RoutinoRunner.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/runner/routino/RoutinoRunner.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4913/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100805/434b9092/attachment.htm