[Marble-devel] Review Request: Removing QPixmap from GeoData-classes

Bastian Holst bastianholst at gmx.de
Fri Apr 30 21:04:42 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3855/
-----------------------------------------------------------

Review request for marble.


Summary
-------

Removing QPixmap from GeoData-classes, as it is not save to be used in a thread other than the ui-thread. GeoData* are created in such a thread.


Diffs
-----

  trunk/KDE/kdeedu/marble/src/lib/VisiblePlacemark.cpp 1120603 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1120603 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.h 1120603 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.cpp 1120603 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.h 1120603 
  trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.cpp 1120603 

Diff: http://reviewboard.kde.org/r/3855/diff


Testing
-------


Thanks,

Bastian



More information about the Marble-devel mailing list