[Marble-devel] Review Request: add APRS data display to marble
Wes Hardaker
wjhns25 at hardakers.net
Thu Apr 29 22:01:47 CEST 2010
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.cpp, line 26
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24948#file24948line26>
> >
> > What is "Direct"? :-)
Not heard through a repeater. IE, they're close enough that your antenna can pick them up directly.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.h, line 11
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24947#file24947line11>
> >
> > AprsFile( const QString & ttyName )
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.cpp, line 1
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24948#file24948line1>
> >
> > License Header (our policy would require it to be LGPL or BSD) missing
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.cpp, line 10
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24948#file24948line10>
> >
> > const QString & filename
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.cpp, line 56
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24948#file24948line56>
> >
> > We always use preincrement when preincrement is meant. So ++m_numErrors.
the comment doesn't make sense considering the increment isn't used right there so it doesn't matter; but I've changed it none-the-less.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherGen.pl, line 1
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24949#file24949line1>
> >
> > License Header (our policy would require it to be LGPL or BSD) missing.
added
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.h, line 36
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24950#file24950line36>
> >
> > Should be an enum.
Why? It's either supposed to dump or not. That's very boolean to me.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.h, line 47
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24950#file24950line47>
> >
> > void addObject( const QString & callSign, ....
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.h, line 49
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24950#file24950line49>
> >
> > routePath, symTable, symCode
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.h, line 60
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24950#file24950line60>
> >
> > m_dumpOutput
ditto on above comment.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 24
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line24>
> >
> > Enum
why?
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 31
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line31>
> >
> > m_sourceName(),
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 44
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line44>
> >
> > bool dumpOutput
why
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 49
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line49>
> >
> > m_dumpOutput(dumpOutput),
case changed (which I think is what you were hinting at)
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 50
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line50>
> >
> > m_seenFrom(seenFrom),
case changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 75
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line75>
> >
> > bool canDoDirect = .....
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 102
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line102>
> >
> > lineLength ....
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 108
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line108>
> >
> > lineLength
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 123
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line123>
> >
> > m_dumpOutput
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 131
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line131>
> >
> > What is XXX ?
changed to TODO tags where needed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 146
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line146>
> >
> > --wheeeee
--fun
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 152
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line152>
> >
> > dstCallDigits
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 174
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line174>
> >
> > myCall, canDoDirect
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 191
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line191>
> >
> > const QString& const QChar &
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 192
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line192>
> >
> > for coordinates it's recommendable to use qreal instead of "float".
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 193
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line193>
> >
> > please use const references for QString and QChar as a method parameter! :) const QString&, const QChar &
I've switched them; note that switching them actually required, however, creating new QString and similar objects since the regexp matcher doesn't spit out references itself.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 214
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line214>
> >
> > newObject. But also you should avoid C++ keywords (like new) as part of member names.
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 229
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line229>
> >
> > I like jokes, but I think we should keep them to a minimum in the code ;-)
It keeps the reader from getting bored. They'll be bored now though.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 232
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line232>
> >
> > camel casing - unless there is a good reason (like copy paste code or C code).
that's actually an odd case due to the specification that mic-e comes from. But I've changed it.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 237
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line237>
> >
> > qreal AprsGatherer::calculateLongitude( const QString&, ... )
fixed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 238
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line238>
> >
> > isEast or rather use an enum.
Left as a bool but upcased
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp, line 241
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24951#file24951line241>
> >
> > threebytes.first().toAscii() ....
AprsGatherer.cpp:235: error: 'const class QString' has no member named 'first'
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.h, line 20
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24953#file24953line20>
> >
> > const QString &
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.h, line 29
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24953#file24953line29>
> >
> > getters don't get prefixed with "get". Just setters are prefixed with "set".
fixed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.h, line 36
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24953#file24953line36>
> >
> > fadeTime, hideTime
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.h, line 40
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24953#file24953line40>
> >
> > m_myName
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.h, line 41
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24953#file24953line41>
> >
> > m_seenFrom
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 57
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24954#file24954line57>
> >
> > please avoid "new" (and use camel casing)
fixed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 32
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24954#file24954line32>
> >
> > const QString &
fixed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 75
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24954#file24954line75>
> >
> > "setPixmap" should use a QPixmap as a parameter. If you want to use a QString for describing the pixmap I'd rather use setPixmapId( const QString & pixmap )
I had issues with pixmaps being created in the wrong thread. The ID got around that.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 143
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24954#file24954line143>
> >
> > ++spot
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 145
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24954#file24954line145>
> >
> > ++spot, ++lastSpot
changed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.h, line 1
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24947#file24947line1>
> >
> > License Header (LGPL) missing
fixed (everywhere)
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.h, line 62
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24950#file24950line62>
> >
> > sourceName
case fixed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 98
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24954#file24954line98>
> >
> > Please use Oxygen Colors.
changed everywhere to stuff from the pallette
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 110
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24954#file24954line110>
> >
> > Q_Assert?
better comment instead.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.h, line 86
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24955#file24955line86>
> >
> > camelCasing
fixed everywhere
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp, line 51
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24956#file24956line51>
> >
> > // Plugin is disabled by default
comment removed.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp, line 53
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24956#file24956line53>
> >
> > // Plugin is visibile by default
comment removed.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp, line 89
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24956#file24956line89>
> >
> > This should really be a name that is commonly understood by any Marble user. I've never heard of "Aprs" but if it was named "Ham Radio" or "Amateur Radio" or something more known that would be better.
Text changed to Amateur Radio Aprs Plugin
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp, line 94
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24956#file24956line94>
> >
> > See comment on line 89
Amateur Radio &Aprs Plugin
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp, line 104
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24956#file24956line104>
> >
> > This should explain in more detail what APRS is about.
Added APRS is a Amateur Radio protocol for broadcasting location and other information
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp, line 120
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24956#file24956line120>
> >
> > What is XXX? Should this be "FIXME:" ?
changed all 3
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp, line 388
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24956#file24956line388>
> >
> > you should use a const iterator here.
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp, line 389
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24956#file24956line389>
> >
> > ++obj
> > and
> > constBegin(), constEnd()
done.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTCPIP.cpp, line 72
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24960#file24960line72>
> >
> > ++m_numErrors;
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTTY.h, line 11
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24961#file24961line11>
> >
> > const QString&
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTTY.cpp, line 64
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24962#file24962line64>
> >
> > ++m_numErrors;
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/GeoAprsCoordinates.h, line 21
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24964#file24964line21>
> >
> > use qreal or GeoDataCoordinates where possible :-)
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/GeoAprsCoordinates.h, line 29
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24964#file24964line29>
> >
> > setTimeStamp( const QTime& );
> >
done (though it isn't beneficial in most places as an object still has to be created)
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/GeoAprsCoordinates.h, line 30
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24964#file24964line30>
> >
> > timeStamp(); (no "get")
fixed
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp, line 100
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24954#file24954line100>
> >
> > Please use Oxygen Colors.
done.
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTCPIP.cpp, line 10
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24960#file24960line10>
> >
> > const QString &
done
> On 2010-04-29 09:32:03, Torsten Rahn wrote:
> > trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer_mic_e.h, line 347
> > <http://reviewboard.kde.org/r/3843/diff/1/?file=24952#file24952line347>
> >
> > The icons don't really match our Quality Requirements. They should use Oxygen colors. Ideally Nuno Pinheiro would create some which would match the required style.
The icons were taken from somewhere else; I'm not an artist and there is no way I could have done them! I'd love to have someone do better versions that what is available today.
I need to go chase down the license for the current one (I thought it was on the page I got them from as GPL-ish but I can't find it now).
- Wes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3843/#review5293
-----------------------------------------------------------
On 2010-04-29 05:30:51, Wes Hardaker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3843/
> -----------------------------------------------------------
>
> (Updated 2010-04-29 05:30:51)
>
>
> Review request for marble.
>
>
> Summary
> -------
>
> Adds support for displaying HAM radio aprs data to the map pulled from three different possible sources. The TCP/IP source is the default that is enabled and usable by everyone. The others would require special sources and default to off. The icons, which are binary files, can be found at: http://www.hardakers.net/code/marble/aprs-icons.tar.gz
>
>
> Diffs
> -----
>
> trunk/KDE/kdeedu/marble/data/CMakeLists.txt 1089346
> trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt 1089346
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsConfigWidget.ui PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsFile.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherGen.pl PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsGatherer_mic_e.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsObject.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsSource.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsSource.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTCPIP.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTCPIP.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTTY.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsTTY.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/CMakeLists.txt PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/GeoAprsCoordinates.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/GeoAprsCoordinates.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/posix_qextserialport.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/qextserialport.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/qextserialport.cpp PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/qextserialport_global.h PRE-CREATION
> trunk/KDE/kdeedu/marble/src/plugins/render/aprs/win_qextserialport.cpp PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/3843/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> screenshot of california with data
> http://reviewboard.kde.org/r/3843/s/378/
>
>
> Thanks,
>
> Wes
>
>
More information about the Marble-devel
mailing list