[Marble-devel] Review Request: Add "Download Region" feature

jensmh at gmx.de jensmh at gmx.de
Sat Apr 24 06:35:34 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3797/
-----------------------------------------------------------

Review request for marble.


Summary
-------

This patch adds the missing bits (mostly UI related) for "Download region".
The .ui are based on those kindly provided by Torsten Rahn.

Remaining issues:
1) the tile level range widget is not shown correctly in the download region dialog
2) UI hangs for some time while the download queue is being filled


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h 1118235 
  /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1118235 
  /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.ui PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1118235 
  /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1118235 
  /trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.h PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.cpp PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/lib/TileLevelRangeWidget.ui PRE-CREATION 
  /trunk/KDE/kdeedu/marble/src/marble_part.h 1118235 
  /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1118235 
  /trunk/KDE/kdeedu/marble/src/marble_part.rc 1118235 

Diff: http://reviewboard.kde.org/r/3797/diff


Testing
-------

- several tests with "current region" as selection method => works minus above issues
- one test with specified lat/lon box => seems to work


Thanks,

jmho



More information about the Marble-devel mailing list