[Marble-devel] Review Request: Determine default map theme based on installed themes

[jensmh at gmx.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3624/#review5150
-----------------------------------------------------------

Ship it!


Looks good (with the explanation about ControlView given on IRC)

- jmho


On 2010-04-16 22:18:30, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3624/
> -----------------------------------------------------------
> 
> (Updated 2010-04-16 22:18:30)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Currently both the KDE and the Qt version use an empty string as the default map theme id, which causes ViewParams to fall back to earth/srtm/srtm.dgml without checking whether it exists. If it is not installed, no theme is selected and the user needs to do it. The patch changes this to select any other installed theme id if earth/srtm/srtm.dgml is not found. This is useful e.g. on Maemo when shipping a "light" version with only the OpenStreetMap map theme installed.
> 
> Note that ViewParams itself cannot determine a fallback map theme dynamically because it does not have access to an instance of MapThemeManager.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/ControlView.h 1115543 
>   /trunk/KDE/kdeedu/marble/src/ControlView.cpp 1115543 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1115543 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1115543 
> 
> Diff: http://reviewboard.kde.org/r/3624/diff
> 
> 
> Testing
> -------
> 
> Removed ~/.config/kde.org/Marble Desktop Globe.conf and earth/srthm/srtm.dgml. Marble selects another map theme then instead of showing a black screen.
> 
> 
> Thanks,
> 
> Dennis
> 
>