[Marble-devel] Review Request: Current Location interface simplification and extension

[Dennis Nienhüser]

> On 2010-04-10 18:28:30, Torsten Rahn wrote:
> > In short: 
> > 
> > > 1) Possibility to choose GPS source in the UI 
> > 
> > At a later point this should maybe get moved into the Configuration dialog.
> > Also this looks still a bit cryptic to a normal user IMHO.
> > "gpsd", "GeoClue" and "Maemo" are fancy names which imho tell little to users such as my dad who has no technical knowledge. I think that the guiString() return values should always be understandable by a user who has got a very limited technical knowledge with regard to computers. While I agree that the previous terms were too long I think that we should try harder to come up with a concise but easy to understand description.
> > 
> > What is even more important to the user is to know:
> > * whether there is a GPS device attached
> > * whether the provided GPS framework is available and works.
> > 
> > If there is a problem (because e.g. the distributed Marble package isn't compiled with GPS support) then there should be some short indication for this problem and a link to a resource which tells which steps are to be take to enable GPS support ("Contact your Distributor." / "Compile in GPS support manually, if you are able to do it yourself").
> > 
> > 2) Condense the UI 
> > 
> > Good.
> > 
> > 3) Allow jumping to the current position
> > 
> > Sounds cool. I have to try it :-)
> > 
> > 
> > > It also removes the custom fonts and the wrong tooltips claiming 
> > > that the map would be re-centered automatically.
> > 
> > Well that was rather a bug with the implementation. 
> > 
> > > The unused label for the fuzzy location description goes away 
> > > as well, although I plan to add it back at some point with 
> > > reverse geocoding information.
> > 
> > Cool, I'm looking forward to this.
> > 
> > Torsten

You're right, it's better to have a checkbox that enables/disables the plugin that got selected in the settings dialog. That also removes the need to put in the artificial "Disabled" entry. I'll look at that.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3549/#review4957
-----------------------------------------------------------


On 2010-04-10 16:05:16, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3549/
> -----------------------------------------------------------
> 
> (Updated 2010-04-10 16:05:16)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> In short: 1) Possibility to choose GPS source in the UI 2) Condense the UI 3) Allow jumping to the current position
> 
> The patch changes the "Current Location" widget in the control box to preserve some whitespace (important on Maemo). It also removes the custom fonts and the wrong tooltips claiming that the map would be re-centered automatically. The unused label for the fuzzy location description goes away as well, although I plan to add it back at some point with reverse geocoding information.
> 
> The "navigation mode" checkbox gets replaced with a combobox that let's you disable position tracking (default at startup) or select one of the available plugins. I favor this for several reasons: You get control over GPS and see what is installed. In case more than one plugin is available, you can switch between them. You can disable GPS, which is most important on embedded devices (GPS drains the battery).
> 
> The longitude and latitude value in the label are links, activating any of them centers the map on the current position.
> 
> 
> This addresses bug 202134.
>     https://bugs.kde.org/show_bug.cgi?id=202134
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.h 1113282 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1113282 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.ui 1113282 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1113282 
>   /trunk/KDE/kdeedu/marble/src/lib/PluginManager.cpp 1113282 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.h 1113282 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.cpp 1113282 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1113282 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1113282 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/geoclue/GeoCluePositionProviderPlugin.cpp 1113282 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp 1113282 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/maemo/MaemoPositionProviderPlugin.cpp 1113282 
> 
> Diff: http://reviewboard.kde.org/r/3549/diff
> 
> 
> Testing
> -------
> 
> Using gpsfake on my desktop system and the internal GPS of my N900.
> 
> 
> Screenshots
> -----------
> 
> marble-current-location-ui.png
>   http://reviewboard.kde.org/r/3549/s/353/
> 
> 
> Thanks,
> 
> Dennis
> 
>