[Marble-devel] Review Request: New Icon for Photo Plugin

[Bastian Holst]

Hi Gabriel,

Thanks for being interested in Marble Junior Jobs. I think the idea of the 
Junior Job was quite different, but that shouldn't stop you from implementing 
your idea.
We were thinking about the QIcon which is returned by WikipediaPlugin::icon() 
to have an icon in the menu. For some reason someone moved this initialization 
of the icon outside of the constructor of WikipediaPlugin, so the icon 
dissappeared from the menu. [1] should fix this issue.
You seem to be thinking of the icon (Wikipedia or Photo) which is displayed on 
the Photo itself or as a substitute to reduce network load, as it's done in 
the Wikipedia code.

About your patch: What you have done seems like a good start, but I don't 
think that it is needed to prerender this image. QIcon could take the svg 
directly and I think (but I'm not sure), QIcon does this optimization itself. 
Perhaps you could run some tests or look this up in the Qt documentation to 
find out if I'm right. Additionally the caching of the ScreenGraphicsItem 
should hold the system load down.
If this is not the case, please change the WikipediaPlugin, too.
Additionally my old code seems to be a bit easier to read, so this should be 
preferred if there are minor or no speed differences.

Again thanks for your work!

Best regards
Bastian


[1] http://websvn.kde.org/?view=rev&revision=1112698

Am Donnerstag, 8. April 2010 20.09:11 schrieb Gabriel Joel Perez:
> Hello!
> 
> I was looking around at the Mable junior jobs to see tasks I could work on
> to help out and get more acquainted with the marble source code. This one
> looked pretty easy:
> http://techbase.kde.org/Projects/Marble/GoMarble/JJ#Add_more_Plugin_Icons
> so I decided to start work on it. I still haven't finished it but I just
> wanted to see if I was going on the right track and if you thought the
> icon was appropriate. I'm basing this on the Wikipedia plugin which
> already has an icon.
> 
> Best Regards,
> Gabriel


-- 
10° 13' 41"O,  54° 24' 38"N
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/marble-devel/attachments/20100408/ac7360ee/attachment.sig