[Marble-devel] Review Request: using other local map directory

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3473/#review4903
-----------------------------------------------------------

Ship it!


Looks good to me. Only issues I see are
* The message should be more user comprehensible
* We should not store data under .kde4 (so that data doesn't get duplicated).

- Torsten


On 2010-04-07 11:33:55, Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3473/
> -----------------------------------------------------------
> 
> (Updated 2010-04-07 11:33:55)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> trying to fix
> https://bugs.kde.org/show_bug.cgi?id=232907 (Marble loads map from another directory than KHNS3 saves them)
> (which is fixed)
> 
> and 
> 
> partly addressing
> https://bugs.kde.org/show_bug.cgi?id=230714 (follow XDG basedir specification)
> 
> I think this can't be done at the same time as KHNS3 saves its data to
> KStandardDirs::locateLocal("data", name)
> 
> which does not follow XDG basedir specification, see
> http://techbase.kde.org/Development/Tutorials/Collaboration/HotNewStuff/Introduction
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/CMakeLists.txt 1112058 
>   trunk/KDE/kdeedu/marble/src/DataMigration.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/DataMigration.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/DataMigrationWidget.ui PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1112058 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.h 1112058 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.cpp 1112058 
>   trunk/KDE/kdeedu/marble/src/marble.knsrc 1112058 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1112058 
> 
> Diff: http://reviewboard.kde.org/r/3473/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bastian
> 
>