[Marble-devel] Review Request: Maemo 5 GPS support

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3491/#review4891
-----------------------------------------------------------

Ship it!


Cool patch! Works as expected.
Before committing you should check for coding style issues!

- Bastian


On 2010-04-04 12:44:38, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3491/
> -----------------------------------------------------------
> 
> (Updated 2010-04-04 12:44:38)
> 
> 
> Review request for marble and Bastian Holst.
> 
> 
> Summary
> -------
> 
> The patch adds a new PositionProvider plugin for Maemo that queries the position from the internal GPS device via Maemo's liblocation library. Once libgps (or geoclue) are easily installable and working on Maemo 5 with its internal GPS device, this patch will not be needed anymore. But for the moment a new plugin feels like the best way to support position tracking on Maemo.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/Findliblocation.cmake PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/CMakeLists.txt 1110245 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/maemo/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/maemo/MaemoPositionProviderPlugin.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/maemo/MaemoPositionProviderPlugin.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3491/diff
> 
> 
> Testing
> -------
> 
> Works happily on my N900 for some hours now. The liblocation library does all the hard work like starting and stopping the GPS device at the right time.
> 
> 
> Thanks,
> 
> Dennis
> 
>