[Marble-devel] Review Request: using other local map directory

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3473/#review4856
-----------------------------------------------------------


Looks good, just change qDebug to mDebug as noted in IRC. I tested both with XDG_DATA_DIR unset and set, works as expected.

I wonder whether we could/should provide some automated data migration or a notification to the user in case old data is lying around in ~/.marble/data?

- Dennis


On 2010-04-01 16:01:20, Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3473/
> -----------------------------------------------------------
> 
> (Updated 2010-04-01 16:01:20)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> trying to fix
> https://bugs.kde.org/show_bug.cgi?id=232907 (Marble loads map from another directory than KHNS3 saves them)
> (which is fixed)
> 
> and 
> 
> partly addressing
> https://bugs.kde.org/show_bug.cgi?id=230714 (follow XDG basedir specification)
> 
> I think this can't be done at the same time as KHNS3 saves its data to
> KStandardDirs::locateLocal("data", name)
> 
> which does not follow XDG basedir specification, see
> http://techbase.kde.org/Development/Tutorials/Collaboration/HotNewStuff/Introduction
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.h 1109967 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.cpp 1109967 
>   trunk/KDE/kdeedu/marble/src/marble.knsrc 1109967 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1109967 
> 
> Diff: http://reviewboard.kde.org/r/3473/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bastian
> 
>