[Marble-devel] Review: Bernhard's patches

[Torsten Rahn]

Just to comment on those patches:

0001-implement-discrete-zoom-steps.patch
0002-implement-discrete-zoom-levels-based-on-eath-radius-.patch

Those look fine to me -- at least it's a base we can improve upon.
Only issue being:
- the "hack" in MarbleWidget::zoomView()
- missing check for the discrete check.
- "radi" -> correct plural: "radii"


0003-implement-custom-storage-layout.patch
That one looks fine to me.

0004-implement-scrolling-with-two-fingers.patch
I guess there are a lot more people who want their scroll-wheel to work as a 
device to zoom (like all other apps do). And I doubt that most people have a 
multitouch touchpad. And then there are the issues that Bernhard mentioned.
So I don't think that this patch should go in.

0005-add-support-for-Google-Maps-map-and-satellite-images.patch
This patch can't get shipped for legal reasons.


0006-check-whether-loading-a-tile-from-disk-was-actually-.patch
Looks good to me on first sight but maybe somebody else can confirm that this 
one does what it's supposed to do (and doesn't have side-effects).

0007-fix-memory-leak.patch
Looks good to me on first sight but maybe somebody else can confirm that this 
one does what it's supposed to do (and doesn't have side-effects).

8-9 basically resemble 1-2 (!?!)

0010-make-zoom-buttons-work-in-discrete-mode.patch
This adds a hack on top of a hack :-/ which makes me wonder whether we can 
bring this into a cleaner shape ....

Regards,

Torsten












Am Montag 19 Oktober 2009 19:42:24 schrieb Torsten Rahn:
> The reviewboard doesn't accept git patches. I'm tired of wasting time into
> making git work for me whenever I run into issues. So here they come in a
> single e-mail for review pleasure.
> 
> Regards,
> 
> Torsten
>