[Marble-devel] QGraphicsView Overlay for marble

[Andrew Manson]

Hi Inge,

Thanks for the input. As an aside, is the use of MarbleWidgetPrivate and 
all this d pointer stuff a named software pattern? if so whats the name 
of it so that i can go and do a little more research on it, i never did 
understand it fully and i sure don't know what you're talking about 
binary compatibility for!  ;)

But about my code, i just put it there to get a quick idea as to what it 
would look like. I intend to try and make it a plugin, i tried this at 
the start but i was having trouble getting it to build and to run. I 
reckon this is just because i don't really know how the plugin system 
works yet, i'm going to have a look at the classes with regards to 
plugins for marble sometime today. Do we have any documentation on this? 
or possibly a How To?

-Andrew

Inge Wallin wrote:
> On Sunday 22 March 2009 19:06:55 Andrew Manson wrote:
>   
>> hi everyone,
>>
>> like i said in my last email I've given the QGraphics stuff a quick
>> go... and i think its been quite successful! I've attached a diff just
>> to show it in action but mind you this is just a HACK! this is not
>> intended to be put into production!!
>>
>> the reason I'm sending this around is because i am just looking for
>> ideas on where to put it... ( in the code i mean! i know it belongs in a
>> branch, so it can't do any damage ;) ) I reckon that i should make it
>> into a plugin but i don't really know how. The only thing that this
>> requires is that it has access to the MarbleWidget so that it can set it
>> as a parent and get information from its methods and slots.
>>
>> Any ideas?
>>     
>
> Hi Andrew,
>
> This may be an interesting development, although I think that you would have 
> to add some geo features into the graphics view as well to make it 
> interesting.  Things like "move this item to a geo position" instead of to 
> just pixel coordinates and things like that.
>
> However, there is a big no-no in the code.  You should not put private members 
> into the MarbleWidget class.  That's what the MarbleWidgetPrivate class is 
> for.  If you do, you will destroy binary compatibility.
>
>   -Inge
>
>
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel
>