[Marble-devel] Marble FileStorageWatcher

[Mülner, Helmut]

Hi,

just to jump in because this is one of the thins I hate most in API (e.g. Windows UpdateData(BOOL):

 > Ok, I'm wearing my API hat / Coding guidelines hat now
 > (and do lots of nitpicking in some cases): 

 >> void startFileWatcher();
 >> void stopFileWatcher();

 > I guess you've swallowed a bit too much init.d there ;-)
 > We encourage to choose APIs that use Qt style conventions:

 > http://doc.trolltech.com/qq/qq13-apis.html

 > Your methods are named like starting and stopping a service. In Qt you usually 
 > just enable or disable features instead: So just having a single method would 
 > be a better solution: 
 
 > setFeature(bool)

Do you mean "The Boolean Parameter Trap"? ;-)

Best regards,

Helmut