[Marble-devel] Review Request: Remove GeoGraphicsItem inheritance in GeoDataObjects

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1106/#review1806
-----------------------------------------------------------

Ship it!


As we had definitely confirmed during GCDS the GeoGraphicsItem inheritance of GeoDataObjects is not the way to go. So this patch looks very much needed.

- Torsten


On 2009-07-23 22:04:01, tgridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1106/
> -----------------------------------------------------------
> 
> (Updated 2009-07-23 22:04:01)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> inheritance of both GeoNode and GeoGraphicsItem is not the way to go...
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1001551 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1001551 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataGeometry.h 1001551 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataGeometry.cpp 1001551 
> 
> Diff: http://reviewboard.kde.org/r/1106/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> tgridel
> 
>