[Marble-devel] Review Request: cppcheck results

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1130/#review1786
-----------------------------------------------------------

Ship it!


Looks all like obvious bugs. None of the leaks are big but of course should get fixed. Thanks!

- Torsten


On 2009-07-25 20:46:31, tgridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1130/
> -----------------------------------------------------------
> 
> (Updated 2009-07-25 20:46:31)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> here are the errors reported by cppcheck:
> Checking ./lib/MarbleDirs.cpp: Q_OS_WIN...
> [./lib/MarbleDirs.cpp:223]: (error) Mismatching allocation and deallocation: appdata_path
> [./lib/MarbleDirs.cpp:238]: (error) Mismatching allocation and deallocation: appdata_path
> 
> Checking ./lib/MeasureTool.cpp...
> [./lib/MeasureTool.cpp:107]: (error) Mismatching allocation and deallocation: x
> 
> Checking ./lib/runners/OnfRunner.cpp...
> [./lib/runners/MarbleAbstractRunner.h:48]: (error) Class MarbleAbstractRunner which is inherited by class OnfRunner does not have a virtual destructor
> 
> Checking ./plugins/positionprovider/geoclue/GeoCute/PositionProvider.cpp...
> [./plugins/positionprovider/geoclue/GeoCute/Provider.h:18]: (error) Class Provider which is inherited by class PositionProvider does not have a virtual destructor
> 
> Checking ./plugins/positionprovider/geoclue/GeoCute/VelocityProvider.cpp...
> [./plugins/positionprovider/geoclue/GeoCute/Provider.h:18]: (error) Class Provider which is inherited by class VelocityProvider does not have a virtual destructor
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.cpp 1002189 
>   /trunk/KDE/kdeedu/marble/src/lib/MeasureTool.cpp 1002189 
>   /trunk/KDE/kdeedu/marble/src/lib/runners/MarbleAbstractRunner.h 1002189 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/geoclue/GeoCute/Provider.h 1002189 
> 
> Diff: http://reviewboard.kde.org/r/1130/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> tgridel
> 
>