[Marble-devel] Review Request: Refresh tiles that are visible on the screen

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1313/#review2016
-----------------------------------------------------------

Ship it!


Looks good to me (except for the connect() which might result in multiple connections established on every redisplay -- I mentioned that on IRC already).

I'd suggest to call the method "reload" in marble_part (which would be consistent with the action in webbrowsers.

I like the tilesOnDisplay() name. Maybe we should rename the tileHash variable likewise.

- Torsten


On 2009-08-12 20:26:10, Torsten Rahn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1313/
> -----------------------------------------------------------
> 
> (Updated 2009-08-12 20:26:10)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Patch by jmho to enable reloading of tiles displayed on the screen.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1010553 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1010553 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1010553 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1010553 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoader.h 1010553 
>   trunk/KDE/kdeedu/marble/src/lib/TileLoader.cpp 1010553 
>   trunk/KDE/kdeedu/marble/src/marble_part.h 1010553 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1010553 
>   trunk/KDE/kdeedu/marble/src/marble_part.rc 1010553 
> 
> Diff: http://reviewboard.kde.org/r/1313/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Torsten
> 
>