[Marble-devel] Review Request: Fix for the ambiguity of the MapQuality enum values

[Andrew Manson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1138/#review1970
-----------------------------------------------------------

Ship it!


- Andrew


On 2009-07-28 00:32:18, Torsten Rahn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1138/
> -----------------------------------------------------------
> 
> (Updated 2009-07-28 00:32:18)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch fixes the ambiguity of the MapQuality enum values:
> 
> http://qt.gitorious.org/qt/pages/ApiDesignPrinciples#Naming+Enum+Types+and+Values
> 
> "When declaring enums, we must keep in mind that in C++, the enum values are used without the type." 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/MarbleTest.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/EquirectScanlineTextureMapper.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/GeoPainter.h 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/GeoPainter.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/MercatorScanlineTextureMapper.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/QtMarbleConfigDialog.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/SphericalScanlineTextureMapper.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/VectorComposer.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/ViewParams.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/global.h 1003157 
>   trunk/KDE/kdeedu/marble/src/lib/graphicsview/MarbleGraphicsItem.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/marble.kcfg 1003157 
>   trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.cpp 1003157 
>   trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.cpp 1003157 
> 
> Diff: http://reviewboard.kde.org/r/1138/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Torsten
> 
>