[Marble-devel] Marble Junior Jobs

[Torsten Rahn]

Hi,

>   I'm the reporter of bug https://bugs.kde.org/show_bug.cgi?id=157784.

Ah! :-)

>   I've done a 10 minutes work on:
> Compile marble with the cmake option -DPEDANTIC=ON. Fix all errors
> that come up until Marble compiles through (MEDIUM).
>  The result is the patch at the botom of the mail:

Looks good to me!

>  If you are happy with my work, I'll continue doint it.

Definetely. This kind of work is very much needed.

>  By the way, I have an svn account so I can patch it directly.

Yes, please do so.

>  Also, as part of the Bugsquad, I'll be glad to do so with marble bugs
> (so little compared to kmail or konqueror !!).

Actually we got lots :)

> Best Regards.
> Jaime Torres Amate.
>
> PD: I'm not subscribed (yet) to marble-devel list.

You should be :)

Best Regards,

Torsten


>
> --- src/lib/geodata/data/GeoDataColorStyle.cpp	2009-04-29
> 16:52:52.000000000 +0200
> +++ src/lib/geodata/data/GeoDataColorStyle.cpp	2009-04-29
> 16:59:56.000000000 +0200
> @@ -44,7 +44,8 @@
>  }
>
>  GeoDataColorStyle::GeoDataColorStyle( const GeoDataColorStyle& other )
> -      : d( new GeoDataColorStylePrivate( *other.d ) )
> +      : GeoDataObject(),
> +        d( new GeoDataColorStylePrivate( *other.d ) )
>  {
>  }
>
> --- src/lib/geodata/data/GeoDataLabelStyle.cpp	2009-04-29
> 16:50:41.000000000 +0200
> +++ src/lib/geodata/data/GeoDataLabelStyle.cpp	2009-04-29
> 16:51:49.000000000 +0200
> @@ -33,9 +33,9 @@
>      }
>
>      GeoDataLabelStylePrivate( const GeoDataLabelStylePrivate& other )
> -        : m_font( other.m_font ),
> +        : m_scale( other.m_scale ),
>            m_alignment( other.m_alignment ),
> -          m_scale( other.m_scale )
> +          m_font( other.m_font )
>      {
>      }
>
> --- src/lib/geodata/data/GeoDataFeature_p.h	2009-04-29 10:23:59.000000000
> +0200 +++ src/lib/geodata/data/GeoDataFeature_p.h	2009-04-29
> 10:34:26.000000000 +0200 @@ -30,25 +30,35 @@
>  {
>    public:
>      GeoDataFeaturePrivate() :
> +        m_name(),
> +        m_description(),
> +        m_address(),
> +        m_phoneNumber(),
> +        m_styleUrl(),
>          m_popularity( 0 ),
>          m_popularityIndex( 19 ),
>          m_visible( true ),
> +        m_visualCategory( GeoDataFeature::Unknown ),
>          m_role(' '),
>          m_style( 0 ),
>          m_styleMap( 0 ),
> -        m_visualCategory( GeoDataFeature::Unknown ),
>          ref( 0 )
>      {
>      }
>
>      GeoDataFeaturePrivate( const GeoDataFeaturePrivate& other ) :
> +        m_name( other.m_name ),
> +        m_description( other.m_description ),
> +        m_address( other.m_address ),
> +        m_phoneNumber( other.m_phoneNumber ),
> +        m_styleUrl( other.m_styleUrl ),
>          m_popularity( other.m_popularity ),
>          m_popularityIndex( other.m_popularityIndex ),
>          m_visible( other.m_visible ),
> +        m_visualCategory( other.m_visualCategory ),
>          m_role( other.m_role ),
>          m_style( other.m_style ),               //FIXME: both style
> and stylemap need to be reworked internally!!!!
>          m_styleMap( other.m_styleMap ),
> -        m_visualCategory( other.m_visualCategory ),
>          ref( 0 )
>      {
>      }
>
> --- src/lib/geodata/data/GeoDataPoint.cpp	2009-04-29 10:39:30.000000000
> +0200 +++ src/lib/geodata/data/GeoDataPoint.cpp	2009-04-29
> 17:10:49.000000000 +0200 @@ -27,15 +27,15 @@
>
>  GeoDataPoint::GeoDataPoint( qreal _lon, qreal _lat, qreal _alt,
>                              GeoDataPoint::Unit unit, int _detail )
> -  : GeoDataGeometry( new GeoDataPointPrivate ),
> -    GeoDataCoordinates( _lon, _lat, _alt,
> -                        static_cast<GeoDataCoordinates::Unit>( unit
> ), _detail )
> +  : GeoDataCoordinates( _lon, _lat, _alt,
> +                        static_cast<GeoDataCoordinates::Unit>( unit
> ), _detail ),
> +    GeoDataGeometry( new GeoDataPointPrivate )
>  {
>  }
>
>  GeoDataPoint::GeoDataPoint( const GeoDataPoint& other )
> -  : GeoDataGeometry( other ),
> -    GeoDataCoordinates( other )
> +  : GeoDataCoordinates( other ),
> +    GeoDataGeometry( other )
>
>  {
>  }
>
> --
> A KDE Contributor.
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel