[Marble-devel] [patch] remove obsolete setDownloadUrl/setDownloadManager methods

[Jens-Michael Hoffmann]

Am Thursday 23 April 2009 14:55:52 schrieb Jens-Michael Hoffmann:
> As discussed on irc, this patch removes the following methods from the
> public API:
>
> void MarbleMap::setDownloadManager( HttpDownloadManager * )
> void MarbleMap::setDownloadUrl( const QString & );
> void MarbleMap::setDownloadUrl( const QUrl & );
>
> void MarbleWidget::setDownloadManager( HttpDownloadManager * );
> void MarbleWidget::setDownloadUrl( const QString & );
> void MarbleWidget::setDownloadUrl( const QUrl & );
>
> The only user of this API inside the KDE svn repository was
> playground/base/plasma/applets/contacts/marblecontactswidget.cpp which is
> changed already in svn revision 958083.
>
> The download urls are stored in the dgml files for quite some time so
> setDownloadUrl is really unnecessary and misleading because it will be
> ignored. Was is being used are the values configured in the dgml.
>
> As I could not see any value of having setDownloadManager, this goes away
> as well, but perhaps I'm missing something here.
>
> Any objections?

oh well, it look's like it broke the FileStorageWatcher, but I'm going to 
repair it now.