[Marble-devel] [Patch] Include own header first

[Jens-Michael Hoffmann]

Am Mittwoch, 16. April 2008 22:28:52 schrieb Inge Wallin:
> > Yes, I've seen it in some of the files. Besides "own header first" is
> > there a technical reason for the order? Or is there a convention in KDE?
>
> Well, I've been using some form of include order.  I.e. own (should always
> be first), posix, qt, kde (kde includes qt but not the other way around),
> marble.  That feels logical to me.

Ok, if this is the convention, I'm fine with it.

But I can't see the reason behind "kde includes qt but not the other way 
around". This really should not matter. Otherwise we should fix the kde 
headers.

> > Instead of "local dir" I would prefer "Marble" because the header need
> > not be in the local dir.
>
> Well, if we have a special module that contains a few files that just
> provide some form of API to the rest of Marble, that should perhaps be
> denoted "local" instead of Marble.  Otherwise "marble" is perfectly ok, I
> think.

"local" sounds good too. I just don't like "local dir".

Best regards

Jens-Michael