[Marble-devel] [Patch] Include own header first

Jens-Michael Hoffmann jensmh at gmx.de
Wed Apr 16 18:21:10 CEST 2008


Am Mittwoch, 16. April 2008 17:56:49 schrieb Torsten Rahn:
> Maybe you've seen it but ingwa recently introduced this kind of scheme that
> explicitely mentions the origin of includes in the comment - just to get
> some cleanup into the include mess :)

Yes, I've seen it in some of the files. Besides "own header first" is there a 
technical reason for the order? Or is there a convention in KDE?

>
> // Own
> #include "MapThemeManager.h"
>
> // KDE
> ...
>
> // Qt
> #include <QtCore/QFile>
> #include <QDebug>
>
> // Local dir
> #include "GeoSceneDocument.h"
> #include "GeoSceneParser.h"
> #include "MarbleDirs.h"

Instead of "local dir" I would prefer "Marble" because the header need not be 
in the local dir.

Best regards

Jens-Michael


More information about the Marble-devel mailing list