[Marble-commits] KDE/kdeedu/marble/src

Jens-Michael Hoffmann jensmh at gmx.de
Fri May 14 20:59:15 CEST 2010


SVN commit 1126736 by jmhoffmann:

MarblePart: Pass non-POD parameters per reference to const.

 M  +2 -2      marble_part.cpp  
 M  +2 -2      marble_part.h  


--- trunk/KDE/kdeedu/marble/src/marble_part.cpp #1126735:1126736
@@ -1233,7 +1233,7 @@
     m_controlView->marbleWidget()->map()->reload();
 }
 
-void MarblePart::showPluginAboutDialog( QString nameId )
+void MarblePart::showPluginAboutDialog( const QString& nameId )
 {
     QList<RenderPlugin *> renderItemList = m_controlView->marbleWidget()->renderPlugins();
 
@@ -1247,7 +1247,7 @@
     }
 }
 
-void MarblePart::showPluginConfigDialog( QString nameId )
+void MarblePart::showPluginConfigDialog( const QString& nameId )
 {
     QList<RenderPlugin *> renderItemList = m_controlView->marbleWidget()->renderPlugins();
 
--- trunk/KDE/kdeedu/marble/src/marble_part.h #1126735:1126736
@@ -134,12 +134,12 @@
     /**
      * Shows the about dialog for the plugin with the corresponding @p nameId.
      */
-    void  showPluginAboutDialog( QString nameId );
+    void  showPluginAboutDialog( const QString& nameId );
 
     /**
      * Shows the configuration dialog for the plugin with the corresponding @p nameId.
      */
-    void  showPluginConfigDialog( QString nameId );
+    void  showPluginConfigDialog( const QString& nameId );
 
     /**
      * Saves the settings of all plugins.


More information about the Marble-commits mailing list