[Marble-commits] KDE/kdeedu/marble/src

Jens-Michael Hoffmann jensmh at gmx.de
Wed May 12 10:18:00 CEST 2010


SVN commit 1125760 by jmhoffmann:

Move comment to where it belongs.

 M  +0 -4      QtMainWindow.cpp  
 M  +4 -0      lib/MarbleModel.cpp  
 M  +0 -4      marble_part.cpp  


--- trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp #1125759:1125760
@@ -884,10 +884,6 @@
     mDebug() << "showDownloadRegionDialog mapThemeId:" << mapThemeId << sourceDir;
 
     if ( dialog->exec() == QDialog::Accepted ) {
-        // FIXME: use lazy evaluation to not generate up to 100k tiles in one go
-        // this can take considerable time even on very fast systems
-        // in contrast generating the TileIds on the fly when they are needed
-        // does not seem to affect download speed.
         TileCoordsPyramid const pyramid = dialog->region();
         model->downloadRegion( sourceDir, pyramid );
     }
--- trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp #1125759:1125760
@@ -943,6 +943,10 @@
         for ( int x = x1; x <= x2; ++x )
             for ( int y = y1; y <= y2; ++y ) {
                 TileId const tileId( mapThemeId, level, x, y );
+                // FIXME: use lazy evaluation to not generate up to 100k tiles in one go
+                // this can take considerable time even on very fast systems
+                // in contrast generating the TileIds on the fly when they are needed
+                // does not seem to affect download speed.
                 d->m_tileLoader->downloadTile( tileId );
             }
     }
--- trunk/KDE/kdeedu/marble/src/marble_part.cpp #1125759:1125760
@@ -1018,10 +1018,6 @@
     QString const mapThemeId = m_controlView->marbleWidget()->mapThemeId();
     QString const sourceDir = mapThemeId.left( mapThemeId.lastIndexOf( '/' ));
     kDebug() << "downloadRegion mapThemeId:" << mapThemeId << sourceDir;
-    // FIXME: use lazy evaluation to not generate up to 100k tiles in one go
-    // this can take considerable time even on very fast systems
-    // in contrast generating the TileIds on the fly when they are needed
-    // does not seem to affect download speed.
     TileCoordsPyramid const pyramid = m_downloadRegionDialog->region();
     m_controlView->marbleWidget()->map()->model()->downloadRegion( sourceDir, pyramid );
 }


More information about the Marble-commits mailing list