[Marble-commits] KDE/kdeedu/marble/src/lib

Jens-Michael Hoffmann jensmh at gmx.de
Sun May 2 03:27:09 CEST 2010


SVN commit 1121654 by jmhoffmann:

DownloadQueueSet: pass arguments by reference to const instead of by value.

 M  +2 -2      DownloadQueueSet.cpp  
 M  +2 -2      DownloadQueueSet.h  


--- trunk/KDE/kdeedu/marble/src/lib/DownloadQueueSet.cpp #1121653:1121654
@@ -101,7 +101,7 @@
     }
 }
 
-void DownloadQueueSet::finishJob( HttpJob * job, QByteArray data )
+void DownloadQueueSet::finishJob( HttpJob * job, const QByteArray& data )
 {
     mDebug() << "finishJob: " << job->sourceUrl() << job->destinationFileName();
 
@@ -112,7 +112,7 @@
     activateJobs();
 }
 
-void DownloadQueueSet::redirectJob( HttpJob * job, QUrl newSourceUrl )
+void DownloadQueueSet::redirectJob( HttpJob * job, const QUrl& newSourceUrl )
 {
     mDebug() << "jobRedirected:" << job->sourceUrl() << " -> " << newSourceUrl;
 
--- trunk/KDE/kdeedu/marble/src/lib/DownloadQueueSet.h #1121653:1121654
@@ -98,8 +98,8 @@
                         const QString& id, DownloadUsage );
 
  private Q_SLOTS:
-    void finishJob( HttpJob * job, QByteArray data );
-    void redirectJob( HttpJob * job, QUrl newSourceUrl );
+    void finishJob( HttpJob * job, const QByteArray& data );
+    void redirectJob( HttpJob * job, const QUrl& newSourceUrl );
     void retryOrBlacklistJob( HttpJob * job, const int errorCode );
 
  private:


More information about the Marble-commits mailing list