[Marble-commits] KDE/kdeedu/marble/src/lib

[Torsten Rahn]

On Saturday 17 July 2010 00:35:48 Thibaut Gridel wrote:
> GeoDataContainer: use folderList instead of folders

Sorry that I only come up with this now that you have committed the patch 
(reason is that I read the patch the other way around):

In Qt APIs the methods that return lists of stuff don't have the suffix "List()". 
They just use the plural:

QList<QGraphicsItem *> QGraphicsScene::items () const

QStringList QFileSystemWatcher::files () const

void QFileSystemWatcher::addPaths ( const QStringList & paths )

QStringList QFileSystemWatcher::directories () const

QList<QAction *> QActionGroup::actions () const

So the original API ("folders()") was correct. Please revert that part. And 
sorry again that I didn't spot it during the review (where I thought that you 
had replaced folderList() with folders(), so my assumption was that you had fixed 
the API instead of making it worse ;-) ).