[Marble-commits] KDE/kdeedu/marble/src

[Jens-Michael Hoffmann]

SVN commit 1076940 by jmhoffmann:

Pass argument by reference instead of by value.

 M  +1 -1      lib/AbstractDataPluginItem.cpp  
 M  +1 -1      lib/AbstractDataPluginItem.h  
 M  +1 -1      plugins/render/weather/WeatherItem.cpp  
 M  +1 -1      plugins/render/weather/WeatherItem.h  
 M  +1 -1      plugins/render/wikipedia/WikipediaItem.cpp  
 M  +1 -1      plugins/render/wikipedia/WikipediaItem.h  


--- trunk/KDE/kdeedu/marble/src/lib/AbstractDataPluginItem.cpp #1076939:1076940
@@ -82,7 +82,7 @@
     d->m_addedAngularResolution = resolution;
 }
 
-void AbstractDataPluginItem::setSettings( QHash<QString, QVariant> settings )
+void AbstractDataPluginItem::setSettings( const QHash<QString, QVariant>& settings )
 {
     d->m_settings = settings;
 }
--- trunk/KDE/kdeedu/marble/src/lib/AbstractDataPluginItem.h #1076939:1076940
@@ -51,7 +51,7 @@
      * This is usually called automatically before painting. If you reimplement this it would be
      * useful to check for changes before copying.
      */
-    virtual void setSettings( QHash<QString, QVariant> settings );
+    virtual void setSettings( const QHash<QString, QVariant>& settings );
     
     /**
      * Returns the action of this specific item.
--- trunk/KDE/kdeedu/marble/src/plugins/render/weather/WeatherItem.cpp #1076939:1076940
@@ -425,7 +425,7 @@
     return QString();
 }
 
-void WeatherItem::setSettings( QHash<QString, QVariant> settings )
+void WeatherItem::setSettings( const QHash<QString, QVariant>& settings )
 {
     if ( d->m_settings == settings ) {
         return;
--- trunk/KDE/kdeedu/marble/src/plugins/render/weather/WeatherItem.h #1076939:1076940
@@ -79,7 +79,7 @@
 
     virtual QString creditHtml() const;
 
-    void setSettings( QHash<QString, QVariant> settings );
+    void setSettings( const QHash<QString, QVariant>& settings );
     
  public Q_SLOTS:
     void openBrowser();
--- trunk/KDE/kdeedu/marble/src/plugins/render/wikipedia/WikipediaItem.cpp #1076939:1076940
@@ -191,7 +191,7 @@
     updateSize();
 }
 
-void WikipediaItem::setSettings( QHash<QString, QVariant> settings )
+void WikipediaItem::setSettings( const QHash<QString, QVariant>& settings )
 {
     if ( settings != m_settings ) {
         m_settings = settings;
--- trunk/KDE/kdeedu/marble/src/plugins/render/wikipedia/WikipediaItem.h #1076939:1076940
@@ -73,7 +73,7 @@
     
     void setIcon( const QIcon& icon );
 
-    void setSettings( QHash<QString, QVariant> settings );
+    void setSettings( const QHash<QString, QVariant>& settings );
     
  public Q_SLOTS:
     void openBrowser();