[Marble-commits] Re: KDE/kdeedu/marble/src

[Dennis Nienhüser]

Hi Anne-Marie,

On 12.12.2010 09:49, Anne-Marie Mahfouf wrote:
> Hi Dennis,
>
> You need to ask *before* committing the permission to include new strings when 
> we reach the string freeze period.

I read the soft message freeze section in the release schedule [1] and
thought it was ok like this. Apparently not; I think that should be more
clear in the document then.

> Usually only important fixes are allowed 
> which is not the case in your commit.
>

Well, I don't agree that mentioning the people who write the code is not
important. But I don't want to start a discussion on that here.

Regards,
Dennis

[1]
http://techbase.kde.org/Schedules/KDE4/4.6_Release_Schedule#Thursday.2C_November_11.2C_2010:_Soft_Message_Freeze

> Thanks in advance for next time,
>
> Anne-Marie
>
> On samedi 11 décembre 2010 22:41:38 Dennis Nienhüser wrote:
>> SVN commit 1205633 by nienhueser:
>>
>> Add missing contributors.
>> CCMAIL: kde-i18n-doc at kde.org
>>
>>  M  +6 -0      kdemain.cpp
>>  M  +4 -0      lib/MarbleAboutDialog.cpp
>>
>>
>> --- trunk/KDE/kdeedu/marble/src/kdemain.cpp #1205632:1205633
>> @@ -95,6 +95,12 @@
>>      aboutData.addAuthor( ki18n( "Dennis Nienhüser" ),
>>                           ki18n( "Routing" ),
>>                           "earthwings at gentoo.org" );
>> +    aboutData.addAuthor( ki18n( "Thibaut Gridel" ),
>> +                         ki18n( "Geodata" ),
>> +                         "tgridel at free.fr" );
>> +    aboutData.addAuthor( ki18n( "Bernhard Beschow" ),
>> +                         ki18n( "WMS Support" ),
>> +                         "bbeschow at cs.tu-berlin.de" );
>>      aboutData.addAuthor( ki18n( "Magnus Valle" ),
>>                           ki18n( "Historical Maps" ),
>>                           "" );
>> --- trunk/KDE/kdeedu/marble/src/lib/MarbleAboutDialog.cpp #1205632:1205633
>> @@ -113,6 +113,10 @@
>>             "<i>APRS Plugin</i></p>")+
>>          tr("<p>Dennis Nienh&uuml;ser <a
>> href=\"mailto:earthwings at gentoo.org\">earthwings at gentoo.org</a><br />"
>> "<i>Routing</i></p>")+
>> +        tr("<p>Thibaut Gridel <a
>> href=\"mailto:tgridel at free.fr\">tgridel at free.fr</a><br />" +          
>> "<i>Geodata</i></p>")+
>> +        tr("<p>Bernhard Beschow <a
>> href=\"mailto:bbeschow at cs.tu-berlin.de\">bbeschow at cs.tu-berlin.de</a><br
>> />" +           "<i>WMS Support</i></p>")+
>>          tr("<b>Join us</b>")+
>>          tr("<p>You can reach the developers of the Marble Project at <a
>> href=\"mailto:marble-devel at kde.org\">marble-devel at kde.org</a></p>")+
>> tr("<b>Google Summer of Code</b>")+
>
>