[Marble-commits] branches/KDE/4.3/kdeedu/marble/src/lib

Torsten Rahn tackat at kde.org
Sat Jul 25 23:21:21 CEST 2009


SVN commit 1002398 by rahn:

- Fixes some few delete vs. delete[] leaks
- Adds some forgotten virtual destructors for abstract classes.



 M  +2 -2      MarbleDirs.cpp  
 M  +1 -1      MeasureTool.cpp  
 M  +1 -1      runners/MarbleAbstractRunner.h  


--- branches/KDE/4.3/kdeedu/marble/src/lib/MarbleDirs.cpp #1002397:1002398
@@ -220,7 +220,7 @@
     
     SHGetSpecialFolderPathW( hwnd, appdata_path, CSIDL_APPDATA, 0 );
     QString appdata = QString::fromUtf16( reinterpret_cast<ushort*>( appdata_path ) );
-    delete appdata_path;
+    delete[] appdata_path;
     return QString( QDir::fromNativeSeparators( appdata ) + "/.marble/data" ); // local path
 #endif
 }
@@ -235,7 +235,7 @@
     
     SHGetSpecialFolderPathW( hwnd, appdata_path, CSIDL_APPDATA, 0 );
     QString appdata = QString::fromUtf16( reinterpret_cast<ushort*>( appdata_path ) );
-    delete appdata_path;
+    delete[] appdata_path;
     return QString( QDir::fromNativeSeparators( appdata ) + "/.marble/plugins" ); // local path
 #endif
 }
--- branches/KDE/4.3/kdeedu/marble/src/lib/MeasureTool.cpp #1002397:1002398
@@ -104,7 +104,7 @@
             }
         }
 
-        delete x;
+        delete[] x;
     }
 }
 
--- branches/KDE/4.3/kdeedu/marble/src/lib/runners/MarbleAbstractRunner.h #1002397:1002398
@@ -49,7 +49,7 @@
     /**
      * Destructor.
      */
-    ~MarbleAbstractRunner();
+    virtual ~MarbleAbstractRunner();
     /**
      * This function gives the  icon for this runner
      * @return the icon of the runner


More information about the Marble-commits mailing list