[Marble-bugs] [marble] [Bug 352156] New: master build uses qtpositioning always but finds it optionally

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=352156

            Bug ID: 352156
           Summary: master build uses qtpositioning always but finds it
                    optionally
           Product: marble
           Version: unspecified
          Platform: Other
               URL: https://launchpadlibrarian.net/216058530/buildlog_ubun
                    tu-wily-amd64.marble_4%3A15.08.0%2Bgit20150901.1105%2B
                    15.10-0_BUILDING.txt.gz
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: sitter at kde.org

In git master there is an optional find_package on qt5positioning

> CMakeLists.txt:   find_package(Qt5Positioning)

and an unprotected include in

> ./src/lib/marble/declarative/Placemark.cpp:#include <QGeoAddress>

ultimately resulting in a build failure if qt5positioning is not found

> ../../../../../src/lib/marble/declarative/Placemark.cpp:14:23: fatal error: QGeoAddress: No such file or directory




Reproducible: Always


Actual Results:  
should either mark qt5positioning REQUIRE in cmake or make the QGeoAddress use
conditional to whether positioning was found

-- 
You are receiving this mail because:
You are the assignee for the bug.