[Marble-bugs] [marble] [Bug 344237] Export geo: URI

[Marius Stanciu]

https://bugs.kde.org/show_bug.cgi?id=344237

--- Comment #16 from Marius Stanciu <stanciumarius94 at gmail.com> ---
OK i've almost completed the patch, but i have a couple of issues on which i
want your opinion:
http://postimg.org/image/aieqt5s3x/
http://postimg.org/image/fdpuk9mlv/

The Copy Coordinates function now pops a dialog  which enables the user to
preview and change the format in which the coordinates will be copied. Dialog
won't appear next time if the checkbox is checked.

Issues:
1. To enable the user to still change the format setting, i had to include the
combobox into the settings dialog. Is the View tab a good placement for this
combobox?
2. Shall the "Don't show this dialog again " thingy last for the current
session only? or should it be saved as a permanent setting?
3. The Copy Coordinates function was implemented twice and DIFFERENTLY in the
original source code. Once for the Edit> Copy Coordinates action, and once for
the right click menu on the marble widget.

Were these two actions supposed to be different? One simply copies a string to
the clipboard, the other builds a quite complex QMimeData object.

As that seemed weird to me, I have centralized the code into a new class,  to
maintain code clarity.
In my implementation, both Copy Coordinate actions now do the same thing(
except that Edit one gets the center of the widget, while the right click one
gets the cursor coordinates ).

-- 
You are receiving this mail because:
You are the assignee for the bug.